Skip to content

chore: Remove cc version requirement & update lockfile to cc v1.2.1 #2969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

matheus23
Copy link
Member

Description

This was getting in my way when I was trying to install both iroh & iroh-blobs from their main branches in a project.

cargo check output
$ cargo check
    Updating git repository `https://github.com/n0-computer/iroh`
    Updating git repository `https://github.com/n0-computer/iroh-blobs`
    Updating crates.io index
error: failed to select a version for `cc`.
    ... required by package `ring v0.17.8`
    ... which satisfies dependency `ring = "^0.17"` (locked to 0.17.8) of package `iroh-net v0.28.1`
    ... which satisfies dependency `iroh-net = "^0.28.1"` (locked to 0.28.1) of package `iroh v0.28.1 (https://github.com/n0-computer/iroh?branch=main#e675bbaf)`
    ... which satisfies dependency `iroh = "^0.28.1"` (locked to 0.28.1) of package `quickstart-iroh v0.1.0 (/home/philipp/program/work/quickstart-iroh)`
versions that meet the requirements `^1.0.83` (locked to 1.2.1) are: 1.2.1

all possible versions conflict with previously selected packages.

  previously selected package `cc v1.1.31`
    ... which satisfies dependency `cc = "=1.1.31"` of package `iroh v0.28.1 (https://github.com/n0-computer/iroh?branch=main#e675bbaf)`
    ... which satisfies dependency `iroh = "^0.28.1"` (locked to 0.28.1) of package `quickstart-iroh v0.1.0 (/home/philipp/program/work/quickstart-iroh)`

failed to select a version for `cc` which could resolve this conflict

Version 1.2 should now fix all the issues we had with it. @dignifiedquire can you check again that this doesn't break your build pretty please (I remember you having issues before).

Change checklist

  • Self-review.
  • [ ] Documentation updates following the style guide, if relevant.
  • [ ] Tests if relevant.
  • [ ] All breaking changes documented.

@matheus23 matheus23 self-assigned this Nov 27, 2024
Copy link

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2969/docs/iroh/

Last updated: 2024-11-27T11:32:00Z

Copy link

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 85db00e

Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a new setup, where this isn't an issue anymore, no idea 🤷

@dignifiedquire dignifiedquire added this to the v0.29.0 milestone Nov 27, 2024
@matheus23 matheus23 added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 0a5379b Nov 27, 2024
25 of 26 checks passed
@matheus23 matheus23 deleted the matheus23/update-cc branch November 27, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants