Skip to content

refactor(iroh): extract docs RPC into iroh-docs #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Nov 13, 2024
Merged

Conversation

dignifiedquire
Copy link
Contributor

Copy link

github-actions bot commented Oct 31, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2868/docs/iroh/

Last updated: 2024-11-13T11:45:56Z

@dignifiedquire dignifiedquire force-pushed the refactor-extract-rpc-docs branch from acd3255 to 940b28d Compare October 31, 2024 11:56
@dignifiedquire dignifiedquire added this to the v0.29.0 milestone Nov 1, 2024
Copy link

github-actions bot commented Nov 7, 2024

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: bc2c3e4

@rklaehn rklaehn marked this pull request as ready for review November 7, 2024 14:22
@rklaehn rklaehn changed the title [WIP] refactor(iroh): extract docs RPC into iroh-docs refactor(iroh): extract docs RPC into iroh-docs Nov 12, 2024
# Conflicts:
#	iroh/src/node/rpc.rs
#	iroh/tests/sync.rs
@rklaehn rklaehn enabled auto-merge November 13, 2024 12:02
Copy link
Contributor Author

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rklaehn rklaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dig says LGTM

@rklaehn rklaehn added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 289b4cf Nov 13, 2024
26 of 27 checks passed
matheus23 pushed a commit that referenced this pull request Nov 14, 2024
Depends on n0-computer/iroh-docs#5

---------

Co-authored-by: Diva M <[email protected]>
Co-authored-by: Ruediger Klaehn <[email protected]>
@rklaehn rklaehn deleted the refactor-extract-rpc-docs branch November 20, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants