Skip to content

refactor(iroh-net): Debug logging should not be per packet set #2818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024
Merged

refactor(iroh-net): Debug logging should not be per packet set #2818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iroh-net/src/magicsock/relay_actor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ impl RelayActor {
url: &RelayUrl,
remote_node: Option<&NodeId>,
) -> relay::client::Client {
debug!(%url, ?remote_node, "connect relay");
trace!(%url, ?remote_node, "connect relay");
// See if we have a connection open to that relay node ID first. If so, might as
// well use it. (It's a little arbitrary whether we use this one vs. the reverse route
// below when we have both.)
Expand Down
8 changes: 1 addition & 7 deletions iroh-net/src/relay/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,12 +561,6 @@ impl Actor {
&mut self,
why: &'static str,
) -> Result<(Conn, &'_ mut ConnReceiver), ClientError> {
debug!(
"connect: {}, current client {}",
why,
self.relay_conn.is_some()
);

if self.is_closed {
return Err(ClientError::Closed);
}
Expand All @@ -590,7 +584,7 @@ impl Actor {

Ok((conn, receiver))
}
.instrument(info_span!("connect", %url))
.instrument(info_span!("connect", %url, %why))
.await
}

Expand Down
Loading