Skip to content

WIP ✨ update node/no-unsupported-features/node-builtins backported URL / URLSearchParams #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

moeriki
Copy link

@moeriki moeriki commented Nov 3, 2019

Fix for #192

URL and URLSearchParams was backported to Node.js v6.13.0.

Notice that I had to set supported to a more complex range for URLSearchParams.

            URLSearchParams: {
                [READ]: { supported: "6.13.0 || >=7.0.0 <7.5.0" },
            },

This is atm not very readable because the supported variable is prefixed with < outside of the config.

Additionally the lint error output is making little sense as well.

The 'url.URLSearchParams' is not supported until Node.js 6.13.0 || >=7.0.0 <7.5.0.
The configured version range is '6.12.3'

Was not sure how to solve best so I'm leaving this PR for discussion.

@mysticatea
Copy link
Owner

Thank you for your contribution.

I'm sorry, I have updated the rule with a different approach. Now the trackMap can have backported property to declare backporting and the error messages contain it.

Thanks.

@moeriki moeriki deleted the issue-192-url-URL-support branch November 25, 2019 09:38
@moeriki
Copy link
Author

moeriki commented Nov 25, 2019

Nice 👍

brettz9 pushed a commit to brettz9/eslint-plugin-node that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants