Skip to content

Update config file #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 15, 2024
Merged

Update config file #584

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3be5a58
Update config file
mxsm Jun 15, 2024
08489ba
update
mxsm Jun 15, 2024
0faeace
update
mxsm Jun 15, 2024
ff7e535
update
mxsm Jun 15, 2024
5bcbbf2
update
mxsm Jun 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/label-on-approval.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@ jobs:

- name: Authenticate with GitHub App
id: auth
uses: mxsm/rocketmq-app
uses: tibdex/github-app-token@v2
with:
app_id: ${{ secrets.APP_ID }} # GitHub App ID
private_key: ${{ secrets.PRIVATE_KEY }} # GitHub App Private Key
app_id: ${{ secrets.APP_ID }}
private_key: ${{ secrets.PRIVATE_KEY }}
- run: "echo 'The created token is masked: ${{ steps.create_token.outputs.token }}'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The echo statement might expose sensitive information. Consider removing it or ensuring it does not log sensitive data.


- name: Check if approval is from Collaborators
id: check_approval
Expand All @@ -35,7 +36,6 @@ jobs:
console.log('No review found.');
return;
}
// Define your list of collaborators
const collaborators = ['mxsm', 'TeslaRustor','SpaceXCN']; // Replace with actual GitHub usernames
console.log('review:', review.state);
console.log('review:', review.state === 'approved');
Expand Down
Loading