Skip to content

[ISSUE #425]🐛Fix the value of the body CRC32 does not match the version in Java #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

mxsm
Copy link
Owner

@mxsm mxsm commented Jun 4, 2024

Which Issue(s) This PR Fixes(Closes)

Fixes #425

Brief Description

How Did You Test This Change?

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 20.74%. Comparing base (0c38933) to head (f10b57e).

Files Patch % Lines
rocketmq-common/src/utils/crc32_utils.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
- Coverage   20.80%   20.74%   -0.06%     
==========================================
  Files         211      211              
  Lines       14421    14423       +2     
==========================================
- Hits         3000     2992       -8     
- Misses      11421    11431      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm mxsm merged commit 774e0c4 into main Jun 4, 2024
8 of 9 checks passed
@mxsm mxsm deleted the bug-425 branch June 4, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The value of the body CRC32 does not match the version in Java.
2 participants