Skip to content

[ISSUE #415]🎨Optmize code logic #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2024
Merged

[ISSUE #415]🎨Optmize code logic #416

merged 1 commit into from
Jun 1, 2024

Conversation

mxsm
Copy link
Owner

@mxsm mxsm commented Jun 1, 2024

Which Issue(s) This PR Fixes(Closes)

Fixes #415

Brief Description

How Did You Test This Change?

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 97 lines in your changes are missing coverage. Please review.

Project coverage is 20.67%. Comparing base (3162ca6) to head (8a8e5e7).

Files Patch % Lines
...q-broker/src/topic/manager/topic_config_manager.rs 0.00% 73 Missing ⚠️
rocketmq-broker/src/out_api/broker_outer_api.rs 0.00% 19 Missing ⚠️
...etmq-remoting/src/clients/rocketmq_default_impl.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
- Coverage   20.67%   20.67%   -0.01%     
==========================================
  Files         207      207              
  Lines       13946    13962      +16     
==========================================
+ Hits         2884     2886       +2     
- Misses      11062    11076      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpaceXCN SpaceXCN merged commit f3a1058 into main Jun 1, 2024
7 of 9 checks passed
@mxsm mxsm deleted the feature-415 branch June 3, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optmize code logic
2 participants