Skip to content

[ISSUE #409]⚡️Optimize RemotingCommand decode and encode #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

mxsm
Copy link
Owner

@mxsm mxsm commented May 31, 2024

Which Issue(s) This PR Fixes(Closes)

Fixes #409

Brief Description

How Did You Test This Change?

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 76.08696% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 19.10%. Comparing base (ff0c3c0) to head (82e7582).

Files Patch % Lines
...ketmq-remoting/src/codec/remoting_command_codec.rs 83.33% 7 Missing ⚠️
rocketmq-remoting/src/protocol/remoting_command.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #410   +/-   ##
=======================================
  Coverage   19.10%   19.10%           
=======================================
  Files         207      207           
  Lines       13828    13842   +14     
=======================================
+ Hits         2642     2645    +3     
- Misses      11186    11197   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm mxsm merged commit 8fe2add into main May 31, 2024
9 checks passed
@mxsm mxsm deleted the en-409 branch May 31, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize RemotingCommand decode and encode
2 participants