Skip to content

[ISSUE #368]🚀Optimize send message logic #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2024
Merged

[ISSUE #368]🚀Optimize send message logic #369

merged 1 commit into from
May 19, 2024

Conversation

mxsm
Copy link
Owner

@mxsm mxsm commented May 19, 2024

Which Issue(s) This PR Fixes(Closes)

Fixes #368

Brief Description

How Did You Test This Change?

Copy link
Contributor

@SpaceOneT SpaceOneT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 28.73563% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 13.59%. Comparing base (7763145) to head (a21ca0a).

Files Patch % Lines
...q-store/src/message_store/default_message_store.rs 0.00% 22 Missing ⚠️
rocketmq-common/src/common/hasher/string_hasher.rs 56.52% 10 Missing ⚠️
rocketmq-store/src/base/append_message_callback.rs 0.00% 9 Missing ⚠️
rocketmq-common/src/utils/util_all.rs 62.50% 6 Missing ⚠️
...tmq-store/src/log_file/mapped_file/default_impl.rs 14.28% 6 Missing ⚠️
...cketmq-common/src/common/message/message_single.rs 0.00% 3 Missing ⚠️
...ketmq-store/src/consume_queue/mapped_file_queue.rs 0.00% 3 Missing ⚠️
rocketmq-store/src/queue/single_consume_queue.rs 0.00% 2 Missing ⚠️
...tmq-broker/src/processor/send_message_processor.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   13.46%   13.59%   +0.12%     
==========================================
  Files         203      204       +1     
  Lines       12495    12554      +59     
==========================================
+ Hits         1683     1707      +24     
- Misses      10812    10847      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm mxsm merged commit 4bf6e4f into main May 19, 2024
9 checks passed
@mxsm mxsm deleted the en-368 branch May 19, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize send message logic
3 participants