Skip to content

[ISSUE #360]🎨Optimize MessageStore recover logic #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

mxsm
Copy link
Owner

@mxsm mxsm commented May 15, 2024

Which Issue(s) This PR Fixes(Closes)

Fixes #360

Brief Description

How Did You Test This Change?

Copy link
Contributor

@SpaceOneT SpaceOneT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 6.00000% with 94 lines in your changes are missing coverage. Please review.

Project coverage is 13.77%. Comparing base (e27e890) to head (a256ce4).

Files Patch % Lines
...ketmq-store/src/consume_queue/mapped_file_queue.rs 18.75% 26 Missing ⚠️
...-store/src/queue/local_file_consume_queue_store.rs 0.00% 15 Missing ⚠️
rocketmq-store/src/base/dispatch_request.rs 0.00% 14 Missing ⚠️
rocketmq-store/src/log_file/commit_log.rs 0.00% 9 Missing ⚠️
rocketmq-broker/src/broker_runtime.rs 0.00% 7 Missing ⚠️
rocketmq-store/src/queue/single_consume_queue.rs 0.00% 7 Missing ⚠️
rocketmq-common/src/common/attribute/cq_type.rs 0.00% 6 Missing ⚠️
rocketmq-common/src/common/config_manager.rs 0.00% 4 Missing ⚠️
...tmq-store/src/log_file/mapped_file/default_impl.rs 0.00% 3 Missing ⚠️
rocketmq-common/src/utils/message_utils.rs 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
- Coverage   13.77%   13.77%   -0.01%     
==========================================
  Files         203      203              
  Lines       12100    12153      +53     
==========================================
+ Hits         1667     1674       +7     
- Misses      10433    10479      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpaceXCN SpaceXCN merged commit f43acbd into main May 15, 2024
7 of 9 checks passed
@SpaceXCN SpaceXCN deleted the en-360 branch May 15, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize MessageStore recover logic
3 participants