Skip to content

[ISSUE #349]🚀Add trait for DefaultMappedFile #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2024
Merged

[ISSUE #349]🚀Add trait for DefaultMappedFile #352

merged 1 commit into from
May 12, 2024

Conversation

mxsm
Copy link
Owner

@mxsm mxsm commented May 12, 2024

Which Issue(s) This PR Fixes(Closes)

Fixes #349

Brief Description

How Did You Test This Change?

Copy link
Contributor

@SpaceOneT SpaceOneT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 5.09091% with 261 lines in your changes are missing coverage. Please review.

Project coverage is 12.66%. Comparing base (b9fe722) to head (3057873).

Files Patch % Lines
...tmq-store/src/log_file/mapped_file/default_impl.rs 7.14% 156 Missing ⚠️
.../src/log_file/mapped_file/default_impl_refactor.rs 0.00% 86 Missing ⚠️
...ketmq-store/src/consume_queue/mapped_file_queue.rs 25.00% 6 Missing ⚠️
rocketmq-store/src/base/append_message_callback.rs 0.00% 5 Missing ⚠️
rocketmq-store/src/log_file/commit_log.rs 0.00% 4 Missing ⚠️
rocketmq-store/src/log_file/mapped_file.rs 0.00% 3 Missing ⚠️
...cketmq-common/src/common/message/message_single.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
- Coverage   12.75%   12.66%   -0.10%     
==========================================
  Files         200      201       +1     
  Lines       11452    11641     +189     
==========================================
+ Hits         1461     1474      +13     
- Misses       9991    10167     +176     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm mxsm merged commit 834542d into main May 12, 2024
7 of 9 checks passed
@mxsm mxsm deleted the en-349 branch May 12, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add trait for DefaultMappedFile
4 participants