Skip to content

[ISSUE #290]🎨Optimize RocketmqDefaultClient code #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

mxsm
Copy link
Owner

@mxsm mxsm commented Mar 25, 2024

Which Issue(s) This PR Fixes(Closes)

Fixes #290

Brief Description

How Did You Test This Change?

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 18.51%. Comparing base (f866ec1) to head (e979dbf).

Files Patch % Lines
...etmq-remoting/src/clients/rocketmq_default_impl.rs 0.00% 10 Missing ⚠️
rocketmq-broker/src/out_api/broker_outer_api.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
+ Coverage   18.45%   18.51%   +0.06%     
==========================================
  Files         164      164              
  Lines        8661     8629      -32     
==========================================
  Hits         1598     1598              
+ Misses       7063     7031      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm mxsm merged commit 431ddc7 into main Mar 25, 2024
8 of 9 checks passed
@mxsm mxsm deleted the feature-290 branch March 25, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize RocketmqDefaultClient code
2 participants