Skip to content

[ISSUE #263]🚧Support register borker(request code:103)-1 #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024
Merged

[ISSUE #263]🚧Support register borker(request code:103)-1 #264

merged 1 commit into from
Mar 12, 2024

Conversation

TeslaRustor
Copy link
Collaborator

Which Issue(s) This PR Fixes(Closes)

Fixes #263

Brief Description

How Did You Test This Change?

@TeslaRustor TeslaRustor requested a review from mxsm March 12, 2024 04:19
Copy link
Owner

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 87 lines in your changes are missing coverage. Please review.

Project coverage is 18.50%. Comparing base (62973ca) to head (08e75b9).

Files Patch % Lines
rocketmq-broker/src/broker_controller.rs 0.00% 48 Missing ⚠️
...q-broker/src/topic/manager/topic_config_manager.rs 0.00% 12 Missing ⚠️
rocketmq-remoting/src/protocol.rs 0.00% 9 Missing ⚠️
...rotocol/static_topic/topic_queue_mapping_detail.rs 0.00% 9 Missing ⚠️
...ol/body/topic_info_wrapper/topic_config_wrapper.rs 0.00% 5 Missing ⚠️
rocketmq-broker/src/broker_config.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
- Coverage   18.69%   18.50%   -0.19%     
==========================================
  Files         162      162              
  Lines        8319     8401      +82     
==========================================
  Hits         1555     1555              
- Misses       6764     6846      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm mxsm merged commit fecc8c7 into mxsm:main Mar 12, 2024
@TeslaRustor TeslaRustor deleted the feature-263 branch March 12, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support register borker(request code:103)-1
2 participants