Skip to content

[ISSUE #234]🚧Implement AppendMessageCallback-1 #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 29, 2024
Merged

[ISSUE #234]🚧Implement AppendMessageCallback-1 #235

merged 2 commits into from
Feb 29, 2024

Conversation

mxsm
Copy link
Owner

@mxsm mxsm commented Feb 29, 2024

Which Issue(s) This PR Fixes(Closes)

Fixes #234

Brief Description

How Did You Test This Change?

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 17.50%. Comparing base (d9e5172) to head (ba26519).

Files Patch % Lines
...tmq-store/src/log_file/mapped_file/default_impl.rs 6.25% 15 Missing ⚠️
rocketmq-store/src/base.rs 0.00% 12 Missing ⚠️
rocketmq-store/src/base/append_message_callback.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   17.30%   17.50%   +0.19%     
==========================================
  Files         147      150       +3     
  Lines        7742     7804      +62     
==========================================
+ Hits         1340     1366      +26     
- Misses       6402     6438      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm mxsm merged commit 7faed93 into main Feb 29, 2024
@mxsm mxsm deleted the feature-234 branch February 29, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Implement AppendMessageCallback-1
2 participants