Deprecate mvdan-sh npm package in favor of sh-syntax
#1145
Assignees
Comments
|
I'm more than happy to entirely remove our js/wasm library here - I don't have the knowledge of JS and Wasm, nor the time to invest into it :) Assuming you're happy to maintain it with updates to the Go module - which shouldn't be too hard as I don't intend to make API breaking changes anytime soon. |
Indeed! It's very smooth to upgrade. See also un-ts/sh-syntax#104 |
|
@mvdan Do you accept a PR for removing |
|
I'll do this myself later today, as I want to include plenty of context for any readers. |
renovate bot
added a commit
to u3u/prettier-config
that referenced
this issue
Apr 10, 2025
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [prettier-plugin-sh](https://redirect.github.com/un-ts/prettier/tree/master/packages/sh) ([source](https://redirect.github.com/un-ts/prettier)) | [`^0.16.0` -> `^0.17.2`](https://renovatebot.com/diffs/npm/prettier-plugin-sh/0.16.0/0.17.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [prettier-plugin-sql](https://redirect.github.com/un-ts/prettier/tree/master/packages/sql) ([source](https://redirect.github.com/un-ts/prettier)) | [`^0.18.1` -> `^0.19.0`](https://renovatebot.com/diffs/npm/prettier-plugin-sql/0.18.1/0.19.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [typescript](https://www.typescriptlang.org/) ([source](https://redirect.github.com/microsoft/TypeScript)) | [`^5.8.2` -> `^5.8.3`](https://renovatebot.com/diffs/npm/typescript/5.8.2/5.8.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>un-ts/prettier (prettier-plugin-sh)</summary> ### [`v0.17.2`](https://redirect.github.com/un-ts/prettier/releases/tag/prettier-plugin-sh%400.17.2) [Compare Source](https://redirect.github.com/un-ts/prettier/compare/[email protected]@0.17.2) ##### Patch Changes - [#​436](https://redirect.github.com/un-ts/prettier/pull/436) [`560ba3f`](https://redirect.github.com/un-ts/prettier/commit/560ba3f1baaf73007366ba7c1285836e15f0db4a) Thanks [@​JounQin](https://redirect.github.com/JounQin)! - feat: make `dockerfile` default, no fallback needed - [#​442](https://redirect.github.com/un-ts/prettier/pull/442) [`dea6b3f`](https://redirect.github.com/un-ts/prettier/commit/dea6b3f7dd8f929d35f1615bace58a6130cef6f7) Thanks [@​JounQin](https://redirect.github.com/JounQin)! - chore: bump `@reteps/dockerfmt` to v0.3.2 **Full Changelog**: https://github.com/un-ts/prettier/compare/[email protected]@0.17.2 ### [`v0.17.1`](https://redirect.github.com/un-ts/prettier/releases/tag/prettier-plugin-sh%400.17.1) [Compare Source](https://redirect.github.com/un-ts/prettier/compare/[email protected]@0.17.1) ##### Patch Changes - [#​433](https://redirect.github.com/un-ts/prettier/pull/433) [`6650f9d`](https://redirect.github.com/un-ts/prettier/commit/6650f9d1f24379b9cf167bfadf338ef8a75c4862) Thanks [@​reteps](https://redirect.github.com/reteps)! - chore: bump `@reteps/dockerfmt`, fix related ESM only usage ### [`v0.17.0`](https://redirect.github.com/un-ts/prettier/releases/tag/prettier-plugin-sh%400.17.0) [Compare Source](https://redirect.github.com/un-ts/prettier/compare/[email protected]@0.17.0) ##### Minor Changes - [#​430](https://redirect.github.com/un-ts/prettier/pull/430) [`f7e38ae`](https://redirect.github.com/un-ts/prettier/commit/f7e38ae6584a42dca99bfdcd5d0237279dcfc865) Thanks [@​JounQin](https://redirect.github.com/JounQin)! - feat(sh): use `sh-syntax` without experimental flag, remove `mvdan-sh` support Please view [mvdan/sh#1145](https://redirect.github.com/mvdan/sh/issues/1145) for more details. - [#​432](https://redirect.github.com/un-ts/prettier/pull/432) [`d49d6e5`](https://redirect.github.com/un-ts/prettier/commit/d49d6e59151de0e875109fbab9baeb70afa3f090) Thanks [@​JounQin](https://redirect.github.com/JounQin)! - feat: prototype to use `dockerfmt` as fallback `printer`, you can also use `parser: dockerfile` to enable it specifically ### [`v0.16.1`](https://redirect.github.com/un-ts/prettier/releases/tag/prettier-plugin-sh%400.16.1) [Compare Source](https://redirect.github.com/un-ts/prettier/compare/[email protected]@0.16.1) ##### Patch Changes - [`facf7ac`](https://redirect.github.com/un-ts/prettier/commit/facf7acb0eff0520a74de4f8f710c8bdaeeb40e9) Thanks [@​JounQin](https://redirect.github.com/JounQin)! - fix: incorrect `require` entry types, add `module-sync` entry </details> <details> <summary>microsoft/TypeScript (typescript)</summary> ### [`v5.8.3`](https://redirect.github.com/microsoft/TypeScript/compare/v5.8.2...68cead182cc24afdc3f1ce7c8ff5853aba14b65a) [Compare Source](https://redirect.github.com/microsoft/TypeScript/compare/v5.8.2...v5.8.3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 2am and before 3am" in timezone Asia/Shanghai, Automerge - "schedule:daily" in timezone Asia/Shanghai. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/u3u/prettier-config). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMzguMCIsInVwZGF0ZWRJblZlciI6IjM5LjIzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Apr 10, 2025
|
I am also reminded that, over a year ago, I already wanted to give up on the JS wrapper built with GopherJS: #1018 (comment) |
|
I have also marked https://www.npmjs.com/package/mvdan-sh as deprecated, so that any existing or new users get a warning against using the package. It's way out of date at this point anyway. @JounQin do you know if I can update the README or description there to point at this issue or your library? I don't seem to be able to. I don't want to publish a new version to update the README, as that would give the impression that the package is maintained, when it is not. |
|
Ah, I managed to do it via |
6 tasks
renovate bot
added a commit
to boneskull/impvol
that referenced
this issue
Apr 11, 2025
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [prettier-plugin-sh](https://redirect.github.com/un-ts/prettier/tree/master/packages/sh) ([source](https://redirect.github.com/un-ts/prettier)) | [`0.16.1` -> `0.17.0`](https://renovatebot.com/diffs/npm/prettier-plugin-sh/0.16.1/0.17.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>un-ts/prettier (prettier-plugin-sh)</summary> ### [`v0.17.0`](https://redirect.github.com/un-ts/prettier/releases/tag/prettier-plugin-sh%400.17.0) [Compare Source](https://redirect.github.com/un-ts/prettier/compare/[email protected]@0.17.0) ##### Minor Changes - [#​430](https://redirect.github.com/un-ts/prettier/pull/430) [`f7e38ae`](https://redirect.github.com/un-ts/prettier/commit/f7e38ae6584a42dca99bfdcd5d0237279dcfc865) Thanks [@​JounQin](https://redirect.github.com/JounQin)! - feat(sh): use `sh-syntax` without experimental flag, remove `mvdan-sh` support Please view [mvdan/sh#1145](https://redirect.github.com/mvdan/sh/issues/1145) for more details. - [#​432](https://redirect.github.com/un-ts/prettier/pull/432) [`d49d6e5`](https://redirect.github.com/un-ts/prettier/commit/d49d6e59151de0e875109fbab9baeb70afa3f090) Thanks [@​JounQin](https://redirect.github.com/JounQin)! - feat: prototype to use `dockerfmt` as fallback `printer`, you can also use `parser: dockerfile` to enable it specifically **Full Changelog**: https://github.com/un-ts/prettier/compare/[email protected]@0.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/boneskull/impvol). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMzguMCIsInVwZGF0ZWRJblZlciI6IjM5LjIzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mvdan-shis very outdated,sh-syntaxis easier to maintain and faster.https://github.com/un-ts/sh-syntax#benchmark
The text was updated successfully, but these errors were encountered: