New style system, take 3. #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one is a lot better and unifies a lot of ideas. Now the Builder only needs to optionally return the views ApplicableStyle. With this, the ViewExt can do all sorts of things like: - style - style_if - class - class_if - or - disabled - hoverable - disabled_if - hoverable_if This introduces a 'StyleState' which can be used to determine whether a view is: - hoverable - disabled To apply a style, `style.apply()` now takes a `StyleApplicator` (a `&Render` or `&Ui`) which returns the evaluated style Instead of weird `args: Self::Args` in the styles, we now have a `StyleOptions<Self::Args>` which has: - hovered: bool - focused: bool - selected: bool - interactive: bool - state: StyleState - args: Self::Args `style.apply()` now also takes a closure for setting the 'args' (the current state from the View for the style to use)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.