Skip to content

🔧 Use MSVC generator for Windows builds over Ninja #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

🔧 Use MSVC generator for Windows builds over Ninja #102

merged 1 commit into from
Apr 22, 2025

Conversation

burgholzer
Copy link
Member

Description

In light of the new Windows 11 ARM runners, this PR switches from using the Ninja generator for the CI on Windows to using the MSVC generator.

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@burgholzer burgholzer added c++ Anything related to C++ code continuous integration Anything related to the CI setup github-actions Pull requests that update Github_actions code labels Apr 22, 2025
@burgholzer burgholzer self-assigned this Apr 22, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 22, 2025
View reviewed changes
.github/workflows/reusable-cpp-tests-windows.yml
if [ "${{ inputs.compiler }}" == "msvc" ]; then
cmake_args="$cmake_args -G Ninja"
elif [ "${{ inputs.compiler }}" == "clang" ]; then
if [ "${{ inputs.compiler }}" == "clang" ]; then

Check warning

Code scanning / CodeQL

Code injection Medium

Potential code injection in
${ inputs.compiler }
Loading
, which may be controlled by an external user.
Potential code injection in
${ inputs.compiler }
Loading
, which may be controlled by an external user.
@burgholzer burgholzer merged commit 15424cf into main Apr 22, 2025
4 checks passed
@burgholzer burgholzer deleted the no-ninja-windows branch April 22, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@burgholzer burgholzer

Labels
c++ Anything related to C++ code continuous integration Anything related to the CI setup github-actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@burgholzer