Skip to content

🚸 improve cpp-linter configuration #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2024

Conversation

burgholzer
Copy link
Member

This PR adds the option to request a full clang-tidy run via a workflow option. This can be useful after updates of the clang-tidy version so that the whole code base can be checked once in a PR and it happens less frequently that warnings then pop up in subsequent PRs.

It also enables the update feature for the cpp-linter thread comment which repeatedly updates the linter comment instead of always creating a new one. This should lower the notification noise.

Setting `files-changed-only: false` on the reusable workflow will trigger clang-tidy to run on all files
@burgholzer burgholzer self-assigned this May 24, 2024
@burgholzer burgholzer added c++ Anything related to C++ code continuous integration Anything related to the CI setup github_actions usability Anything related to usability labels May 24, 2024
@burgholzer burgholzer merged commit 2df0b74 into main May 24, 2024
2 checks passed
@burgholzer burgholzer deleted the update-clang-tidy-configuration branch May 24, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code continuous integration Anything related to the CI setup usability Anything related to usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant