Skip to content

Investigate bad_caston Mac OS 15 in Python tests #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

ystade
Copy link
Collaborator

@ystade ystade commented May 8, 2025

Description

#641 reveals a spurious bug that cannot be reproduced locally. This PR aims to find and fix the bug.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@github-project-automation github-project-automation bot moved this to In Progress in MQT Compilation May 8, 2025
@burgholzer burgholzer changed the base branch from main to org-move May 8, 2025 08:04
@ystade ystade force-pushed the investigate-mac-bug branch from ad74cee to e19ef94 Compare May 8, 2025 08:09
@ystade ystade force-pushed the investigate-mac-bug branch from e19ef94 to bca9a0e Compare May 8, 2025 08:14
@ystade ystade added extensive-python-ci Adding this label indicates that extensive Python CI runs should be started for this PR. extensive-cpp-ci Adding this label indicates that extensive C++ CI runs should be started for this PR. labels May 8, 2025
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.5%. Comparing base (4fa3fa3) to head (dfa8b39).
Report is 4 commits behind head on org-move.

❌ Your project status has failed because the head coverage (94.3%) is below the adjusted base coverage (96.1%). You can increase the head coverage or adjust the Removed Code Behavior.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           org-move    #642     +/-   ##
==========================================
- Coverage      90.6%   90.5%   -0.1%     
==========================================
  Files           103     103             
  Lines         10670   10689     +19     
  Branches       1817    1817             
==========================================
+ Hits           9671    9680      +9     
- Misses          999    1009     +10     
Flag Coverage Δ *Carryforward flag
cpp 90.4% <100.0%> (+<0.1%) ⬆️ Carriedforward from a784c52
python 94.3% <ø> (-2.4%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
src/na/nasp/Solver.cpp 94.2% <100.0%> (+0.2%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@burgholzer
Copy link
Member

dfa8b39 seems to have actually fixed the underlying problem.
I don't fully get why and how, but it definitely had to do with the fact that the minimums build would download mqt-core==3.0.0 which, eventually, would not pass the find_package(mqt-core 3.0.2 REQUIRED) call hidden in our FetchContent directive.
That leads to mqt-core==3.0.2 to be fetched and built into the wheel.
At the same time, mqt-core==3.0.0 is installed in the virtual environment and used when running the tests.
I am fairly sure that the problem arises from slightly different compilers used for compiling the two mqt-core libraries.
This has been resolved in #641 by introducing a new minimum version variable for the FetchContent call that allows 3.0.0 to be used.

@burgholzer burgholzer closed this May 8, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in MQT Compilation May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensive-cpp-ci Adding this label indicates that extensive C++ CI runs should be started for this PR. extensive-python-ci Adding this label indicates that extensive Python CI runs should be started for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants