-
Notifications
You must be signed in to change notification settings - Fork 36
⬆️ Update munich-quantum-toolkit/core
#610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Update munich-quantum-toolkit/core
#610
Conversation
17e8ad9
to
8bb8566
Compare
8bb8566
to
4499041
Compare
@burgholzer, we suddenly get segmentation faults in the C++ and Python tests. The tests failed right from the start, before the upgrade to C++20. The failing tests are all testing the hybrid circuit simulator in DD mode. Do you have any idea which change in Core could cause this? 🤔 |
That is certainly strange. The Windows tests in Debug mode are most helpful in this case: https://github.com/munich-quantum-toolkit/ddsim/actions/runs/16657462556/job/47146024096#step:6:1 |
Hm I don't see any particular change in 3.2 that could have caused this. Maybe something on the C++20 went wrong but unnoticed in mqt-core. At least it's a consistent failure. If you happen to have a Windows (virtual) machine around, running in debug mode with MSVC and a debugger attached is probably the easiest way to identify, what exactly is going wrong. |
The problem is fixed by munich-quantum-toolkit/core#1088. Once this is merged, I'll create a patch release in Core so that we can revert 1887ab8 and require |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1887ab8
to
9ea1ef0
Compare
9ea1ef0
to
6b8119c
Compare
6b8119c
to
9ea1ef0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This will also need a lockfile update after the changes.
Co-authored-by: Lukas Burgholzer <[email protected]> Signed-off-by: Daniel Haag <[email protected]>
Signed-off-by: Daniel Haag <[email protected]>
This pull request updates the munich-quantum-toolkit/core dependency from munich-quantum-toolkit/core@1f95d92 (version v3.1.0) to munich-quantum-toolkit/core@28e41bf (version v3.2.0).
Full Changelog: munich-quantum-toolkit/core@1f95d92...28e41bf