Skip to content

⬆️ Update munich-quantum-toolkit/core #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mqt-app[bot]
Copy link
Contributor

@mqt-app mqt-app bot commented Jul 31, 2025

This pull request updates the munich-quantum-toolkit/core dependency from munich-quantum-toolkit/core@1f95d92 (version v3.1.0) to munich-quantum-toolkit/core@28e41bf (version v3.2.0).

Full Changelog: munich-quantum-toolkit/core@1f95d92...28e41bf

@mqt-app mqt-app bot added c++ Anything related to C++ code dependencies Pull requests that update a dependency file labels Jul 31, 2025
@github-project-automation github-project-automation bot moved this to In Progress in MQT Simulation Jul 31, 2025
@denialhaag denialhaag self-assigned this Jul 31, 2025
@denialhaag denialhaag force-pushed the update-mqt-core-28e41bf9516b5f103ea4002810f5b87e0b5450bc branch from 17e8ad9 to 8bb8566 Compare July 31, 2025 17:09
@denialhaag denialhaag force-pushed the update-mqt-core-28e41bf9516b5f103ea4002810f5b87e0b5450bc branch from 8bb8566 to 4499041 Compare July 31, 2025 17:44
@denialhaag
Copy link
Contributor

@burgholzer, we suddenly get segmentation faults in the C++ and Python tests. The tests failed right from the start, before the upgrade to C++20. The failing tests are all testing the hybrid circuit simulator in DD mode. Do you have any idea which change in Core could cause this? 🤔

@burgholzer
Copy link
Member

@burgholzer, we suddenly get segmentation faults in the C++ and Python tests. The tests failed right from the start, before the upgrade to C++20. The failing tests are all testing the hybrid circuit simulator in DD mode. Do you have any idea which change in Core could cause this? 🤔

That is certainly strange. The Windows tests in Debug mode are most helpful in this case: https://github.com/munich-quantum-toolkit/ddsim/actions/runs/16657462556/job/47146024096#step:6:1
I'll the check the mqt-core changes. Probably something related to reference counting, but I am not sure. I thought these changes were already in 3.1

@burgholzer
Copy link
Member

Hm I don't see any particular change in 3.2 that could have caused this.
I would have suspected munich-quantum-toolkit/core#1020, but that was already part of 3.1

Maybe something on the C++20 went wrong but unnoticed in mqt-core.

At least it's a consistent failure. If you happen to have a Windows (virtual) machine around, running in debug mode with MSVC and a debugger attached is probably the easiest way to identify, what exactly is going wrong.

@denialhaag
Copy link
Contributor

denialhaag commented Jul 31, 2025

The problem is fixed by munich-quantum-toolkit/core#1088. Once this is merged, I'll create a patch release in Core so that we can revert 1887ab8 and require v3.2.1 here.

Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@denialhaag denialhaag force-pushed the update-mqt-core-28e41bf9516b5f103ea4002810f5b87e0b5450bc branch from 1887ab8 to 9ea1ef0 Compare July 31, 2025 22:40
@mqt-app mqt-app bot force-pushed the update-mqt-core-28e41bf9516b5f103ea4002810f5b87e0b5450bc branch from 9ea1ef0 to 6b8119c Compare August 1, 2025 01:44
@denialhaag denialhaag force-pushed the update-mqt-core-28e41bf9516b5f103ea4002810f5b87e0b5450bc branch from 6b8119c to 9ea1ef0 Compare August 1, 2025 08:12
@denialhaag denialhaag requested a review from burgholzer August 1, 2025 10:43
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will also need a lockfile update after the changes.

denialhaag and others added 3 commits August 1, 2025 12:54
Co-authored-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Daniel Haag <[email protected]>
@denialhaag denialhaag enabled auto-merge (squash) August 1, 2025 10:57
@denialhaag denialhaag merged commit cf2b59b into main Aug 1, 2025
34 checks passed
@denialhaag denialhaag deleted the update-mqt-core-28e41bf9516b5f103ea4002810f5b87e0b5450bc branch August 1, 2025 11:33
@github-project-automation github-project-automation bot moved this from In Progress to Done in MQT Simulation Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants