Skip to content

✨ Make Python enums PEP-435 compatible #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2025
Merged

✨ Make Python enums PEP-435 compatible #607

merged 3 commits into from
Jul 30, 2025

Conversation

denialhaag
Copy link
Contributor

@denialhaag denialhaag commented Jul 30, 2025 •
edited
Loading

Description

This PR exposes enums to Python via pybind11's new enum.Enum-compatible py::native_enum.

Related to munich-quantum-toolkit/core#1075

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@github-project-automation github-project-automation bot moved this to In Progress in MQT Simulation Jul 30, 2025
@denialhaag denialhaag added enhancement Anything related to improvements of the existing library python Pull requests that update Python code minor Part of a minor release c++ Anything related to C++ code labels Jul 30, 2025
@denialhaag denialhaag self-assigned this Jul 30, 2025
@denialhaag denialhaag requested a review from burgholzer July 30, 2025 17:26
@codecov Codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

burgholzer
burgholzer approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@denialhaag denialhaag enabled auto-merge (squash) July 30, 2025 18:16
@denialhaag denialhaag merged commit c4bf4e8 into main Jul 30, 2025
34 checks passed
@denialhaag denialhaag deleted the native-enum branch July 30, 2025 18:59
@github-project-automation github-project-automation bot moved this from In Progress to Done in MQT Simulation Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burgholzer burgholzer burgholzer approved these changes

Assignees

@denialhaag denialhaag

Labels
c++ Anything related to C++ code enhancement Anything related to improvements of the existing library minor Part of a minor release python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denialhaag @burgholzer