-
Notifications
You must be signed in to change notification settings - Fork 34
Add Reset Operation in Simulator #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
=====================================
Coverage 95.0% 95.0%
=====================================
Files 20 20
Lines 1940 1950 +10
Branches 345 348 +3
=====================================
+ Hits 1843 1853 +10
Misses 97 97
|
Just as a small hint: you could actually adapt some of the MQT Core tests for dynamic circuits here. |
Additional side note: the Qiskit backends probably should add the Reset gate as a supported operation and should also be tested. |
Cpp-Linter Report ✔️No problems need attention. Have any feedback or feature suggestions? Share it here. |
Good point, I'd do this as addition to or after #267 to avoid just creating conflicts in merging. |
Agreed! 👍🏻 then this is good to go from my end! |
This PR adds the non-unitary reset operation to DDSIM.
Fixes #270