Skip to content

Fix Compiler Warnings #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Fix Compiler Warnings #266

merged 1 commit into from
Jul 25, 2023

Conversation

hillmich
Copy link
Contributor

  • Fix compiler warnings, mostly shadowing variables

- Fix compiler warnings, mostly shadowing variables
@hillmich hillmich self-assigned this Jul 24, 2023
@github-actions
Copy link
Contributor

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #266 (6cea747) into main (08304cf) will decrease coverage by 0.1%.
The diff coverage is 94.7%.

@@           Coverage Diff           @@
##            main    #266     +/-   ##
=======================================
- Coverage   95.0%   94.9%   -0.1%     
=======================================
  Files         20      20             
  Lines       1937    1940      +3     
  Branches     344     345      +1     
=======================================
+ Hits        1841    1842      +1     
- Misses        96      98      +2     
Impacted Files Coverage Δ
src/StochasticNoiseSimulator.cpp 95.5% <80.0%> (-0.5%) ⬇️
include/DeterministicNoiseSimulator.hpp 100.0% <100.0%> (ø)
include/ShorFastSimulator.hpp 100.0% <100.0%> (ø)
include/StochasticNoiseSimulator.hpp 95.6% <100.0%> (ø)
src/ShorFastSimulator.cpp 95.5% <100.0%> (ø)

... and 2 files with indirect coverage changes

@hillmich hillmich merged commit cd1a8b2 into main Jul 25, 2023
@hillmich hillmich deleted the fix-warnings branch July 25, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant