Skip to content

Move Python Information to pyproject.toml #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 14, 2022
Merged

Move Python Information to pyproject.toml #167

merged 10 commits into from
Dec 14, 2022

Conversation

hillmich
Copy link
Contributor

No description provided.

@hillmich hillmich self-assigned this Dec 13, 2022
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #167 (dab38f2) into main (0c8f643) will increase coverage by 0.0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #167   +/-   ##
=====================================
  Coverage   86.7%   86.8%           
=====================================
  Files         20      20           
  Lines       2026    2026           
  Branches     387     387           
=====================================
+ Hits        1757    1759    +2     
+ Misses       269     267    -2     
Impacted Files Coverage Δ
src/ShorSimulator.cpp 60.8% <0.0%> (+0.2%) ⬆️
src/ShorFastSimulator.cpp 94.4% <0.0%> (+0.3%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hillmich hillmich marked this pull request as ready for review December 13, 2022 13:26
@hillmich hillmich requested a review from burgholzer December 13, 2022 13:26
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just went through all the changes. Many thanks first of all.
You can find a couple of comments down below. Most are just about loosening some of the dependencies.

In addition, you have to remove the musl wheels job from the branch protection in order for the CI checks to turn green.

Probably the biggest thing: You are no longer building wheels for Apple Silicon which seems like an oversight to me. If you just followed QCEC, then it has been replaced by a native runner on Cirrus CI there (see https://github.com/cda-tum/qcec/blob/main/.cirrus.yml).
I believe you could follow QMAP for cross-compiling wheels for Apple Silicon.

P.S.: minor nitpick, but please consider adding a description to this PR.

@hillmich hillmich requested a review from burgholzer December 14, 2022 11:44
@hillmich hillmich merged commit eb94724 into main Dec 14, 2022
@hillmich hillmich deleted the update-pyproject branch December 14, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants