-
Notifications
You must be signed in to change notification settings - Fork 34
Move Python Information to pyproject.toml #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #167 +/- ##
=====================================
Coverage 86.7% 86.8%
=====================================
Files 20 20
Lines 2026 2026
Branches 387 387
=====================================
+ Hits 1757 1759 +2
+ Misses 269 267 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
- also add currency to the actions runs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just went through all the changes. Many thanks first of all.
You can find a couple of comments down below. Most are just about loosening some of the dependencies.
In addition, you have to remove the musl
wheels job from the branch protection in order for the CI checks to turn green.
Probably the biggest thing: You are no longer building wheels for Apple Silicon which seems like an oversight to me. If you just followed QCEC, then it has been replaced by a native runner on Cirrus CI there (see https://github.com/cda-tum/qcec/blob/main/.cirrus.yml).
I believe you could follow QMAP for cross-compiling wheels for Apple Silicon.
P.S.: minor nitpick, but please consider adding a description to this PR.
No description provided.