♻️ Refactor QASM import functionality and remove deprecated formats #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ♻️ turn QASM parser into its own library - 🔥 remove import functionality from `QuantumComputation` the respective functionality is now provided by a separate `MQT::CoreQASM` library - ♻️ refactor QASM parser and improve imports Signed-off-by: burgholzer <[email protected]>
burgholzer
added
refactor
Signed-off-by: burgholzer <[email protected]>
burgholzer
force-pushed
the
remove-non-qasm-parsers
branch
from
0e6105c to
5cb74d6
Compare
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
4 tasks
burgholzer
added a commit
to munich-quantum-toolkit/syrec
that referenced
this pull request
Feb 4, 2025
## Description This moves the `.real` parser from MQT Core, where it has been removed in munich-quantum-toolkit/core#822, to this repository. As there are no previous connection points to the SyReC repository, this is relatively standalone for now. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the QASM import functionality by encapsulating the QASM parser into its own dedicated library,
MQT::CoreQASM. This change removes the import functionality from theQuantumComputationclass, improving modularity and maintainability. Additionally, deprecated formats have been removed, streamlining the codebase.Notably, this removes support for parsing
.realfiles. Corresponding support is expected to be integrated into the MQT SyReC Synthesizer at https://github.com/cda-tum/mqt-syrec.Checklist: