♻️🎨 Code cleanup and refactors #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgholzer
added
usability
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Signed-off-by: burgholzer <[email protected]>
- opting for references where null values are not expected or accepted. - moving code from headers to source files. - fixing new clang-tidy warnings - adding a little more noexcept were appropriate Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Replaced raw pointer usages with references across the codebase for improved clarity and type safety. This adjustment simplifies operations and ensures consistency, particularly when applying, measuring, or resetting operations in simulation and functionality logic. Corresponding tests have been updated to reflect this change. Signed-off-by: burgholzer <[email protected]>
This is only used in one part of DDSIM that is scheduled for removal. And removed code is debugged code. Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
these members had getters since a while back. there is no need to keep them as public members. Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
burgholzer
force-pushed
the
early-2025-cleanup
branch
from
a1db201 to
be416f2
Compare
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
burgholzer
force-pushed
the
early-2025-cleanup
branch
from
be416f2 to
c381adb
Compare
4 tasks
burgholzer
added a commit
to munich-quantum-toolkit/qcec
that referenced
this pull request
Jan 12, 2025
## Description This PR updates the MQT Core version used in QCEC to the latest version. This includes changes from munich-quantum-toolkit/core#798. Algorithms are now constructed slightly differently and some of the methods now take references instead of pointers. This PR also fixes one compiler warning related to a potential uniniatialized usage in the equivalence checking manager. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting the year with some obligatory code cleanup and refactors.
The individual commits and the commit messages should more or less convey the bigger changes.
For the most part, it's really all about defining clearer interfaces and following some new clang-tidy suggestions.
Checklist: