Skip to content

⬆️ require pybind11 >= 2.13.5 #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2024
Merged

⬆️ require pybind11 >= 2.13.5 #679

merged 2 commits into from
Sep 5, 2024

Conversation

burgholzer
Copy link
Member

Description

This small PR updates the requirement on pybind11 to 2.13.5 which contains a fix for some relative paths that could trip up compilers.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer self-assigned this Sep 5, 2024
@burgholzer burgholzer added dependencies Pull requests that update a dependency file fix Fix for something that isn't working Core Anything related to the Core library and IR python Anything related to Python code labels Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.1%. Comparing base (28dc65e) to head (c045b74).
Report is 115 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #679   +/-   ##
=====================================
  Coverage   87.0%   87.1%           
=====================================
  Files        125     125           
  Lines      13781   13780    -1     
  Branches    2164    2164           
=====================================
+ Hits       11995   12006   +11     
+ Misses      1786    1774   -12     
Flag Coverage Δ
cpp 86.7% <ø> (+<0.1%) ⬆️
python 99.7% <ø> (ø)

see 2 files with indirect coverage changes

@burgholzer burgholzer added this to the MQT Core milestone Sep 5, 2024
@burgholzer burgholzer enabled auto-merge (squash) September 5, 2024 11:57
@burgholzer burgholzer merged commit 64e35f7 into main Sep 5, 2024
34 checks passed
@burgholzer burgholzer deleted the pybind11 branch September 5, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Anything related to the Core library and IR dependencies Pull requests that update a dependency file fix Fix for something that isn't working python Anything related to Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant