-
Notifications
You must be signed in to change notification settings - Fork 35
Zero-ancilla partial equivalence checking #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zero-ancilla partial equivalence checking #532
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
=====================================
Coverage 91.3% 91.3%
=====================================
Files 130 130
Lines 13851 13857 +6
Branches 2151 2153 +2
=====================================
+ Hits 12655 12665 +10
+ Misses 1196 1192 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the pull request! Overall this is looking really good already. Just a couple of very minor comments that would be nice to address. After that, this is good to go ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the additional changes. Looking all good now! 😌
Description
Changed
isCloseToIdentityRecursive
such that it supports garbage qubits and a flag can be added to only check if it's close to a diagonal matrix, without checking that the diagonal entries are close to one.With this function, zero-ancilla partial equivalence can be checked as described in the paper "Partial Equivalence Checking of Quantum Circuits" by Chen et al.
Checklist: