⚡ Skip symmetry
computation and 🔥 remove transpose
method
#442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the computation of the
isSymmetric
property in matrix DDs.The corresponding check was conducted on every node creation in
makeDDNode
and the resulting property was only used as a shortcut in thetranspose
method.However, the
transpose
method is not used anywhere in our codebase.As a consequence, this PR also removes the
transpose
method to reduce the amount of code bloat in our code base.Overall, this should yield a small net performance gain for every operation involving matrices.
Checklist: