Skip to content

⚡ Skip symmetry computation and 🔥 remove transpose method #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

burgholzer
Copy link
Member

Description

This PR removes the computation of the isSymmetric property in matrix DDs.
The corresponding check was conducted on every node creation in makeDDNode and the resulting property was only used as a shortcut in the transpose method.
However, the transpose method is not used anywhere in our codebase.
As a consequence, this PR also removes the transpose method to reduce the amount of code bloat in our code base.

Overall, this should yield a small net performance gain for every operation involving matrices.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added enhancement New feature or request DD Anything related to the DD package c++ Anything related to C++ code labels Oct 15, 2023
@burgholzer burgholzer added this to the DD Package Improvements milestone Oct 15, 2023
@burgholzer burgholzer self-assigned this Oct 15, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #442 (5925309) into main (9ad0c72) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #442     +/-   ##
=======================================
- Coverage   90.1%   90.0%   -0.1%     
=======================================
  Files        108     108             
  Lines      11889   11853     -36     
  Branches    2089    2082      -7     
=======================================
- Hits       10712   10676     -36     
  Misses      1177    1177             
Flag Coverage Δ
cpp 89.8% <100.0%> (-0.1%) ⬇️
python 100.0% <ø> (ø)
Files Coverage Δ
include/dd/Node.hpp 100.0% <ø> (ø)
include/dd/Package.hpp 94.3% <100.0%> (-0.1%) ⬇️
include/dd/statistics/PackageStatistics.hpp 100.0% <ø> (ø)

@github-actions
Copy link
Contributor

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

@burgholzer burgholzer merged commit 49a8635 into main Oct 16, 2023
@burgholzer burgholzer deleted the retire-transpose branch October 16, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code DD Anything related to the DD package enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant