Skip to content

🐛 Fix Barrier handling in remove final measurements optimisation #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

burgholzer
Copy link
Member

Description

Fixes a newly introduced bug in the remove final measurements optimisation that surfaced in QCEC due to the way how Barrier gates are handled since there promotion from a NonUnitaryOperation to a StandardOperation.
Barriers are now treated similarly to measurements and a test is added to prevent future regressions.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added fix Fix for something that isn't working Core Anything related to the Core library and IR c++ Anything related to C++ code labels Aug 21, 2023
@burgholzer burgholzer added this to the MQT Core milestone Aug 21, 2023
@burgholzer burgholzer self-assigned this Aug 21, 2023
@burgholzer burgholzer enabled auto-merge August 21, 2023 06:23
@github-actions
Copy link
Contributor

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #403 (6bed869) into main (819e729) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #403   +/-   ##
=====================================
  Coverage   89.3%   89.3%           
=====================================
  Files         98      98           
  Lines      11634   11627    -7     
  Branches    2084    2081    -3     
=====================================
- Hits       10392   10387    -5     
+ Misses      1242    1240    -2     
Flag Coverage Δ
cpp 89.3% <100.0%> (+<0.1%) ⬆️
python 100.0% <ø> (ø)
Files Changed Coverage Δ
src/CircuitOptimizer.cpp 85.2% <100.0%> (+0.1%) ⬆️

@burgholzer burgholzer merged commit ba5244e into main Aug 21, 2023
@burgholzer burgholzer deleted the fix-remove-final-measurements branch August 21, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code Core Anything related to the Core library and IR fix Fix for something that isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant