Skip to content

🔧 Disable NullDereference clang-tidy check #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Conversation

burgholzer
Copy link
Member

Description

This PR disables the NullDereference clang-tidy check since it led to many false positives.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Lukas Burgholzer <[email protected]>
@burgholzer burgholzer added fix Fix for something that isn't working Core Anything related to the Core library and IR c++ Anything related to C++ code labels Jul 26, 2023
@burgholzer burgholzer added this to the MQT Core milestone Jul 26, 2023
@burgholzer burgholzer self-assigned this Jul 26, 2023
@github-actions
Copy link
Contributor

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #383 (7c4c636) into main (5634aae) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #383   +/-   ##
=====================================
  Coverage   89.1%   89.1%           
=====================================
  Files         97      97           
  Lines      11712   11708    -4     
  Branches    2103    2101    -2     
=====================================
- Hits       10436   10434    -2     
+ Misses      1276    1274    -2     
Files Changed Coverage Δ
include/dd/UniqueTable.hpp 100.0% <100.0%> (+1.9%) ⬆️

@burgholzer burgholzer merged commit 20e90a9 into main Jul 26, 2023
@burgholzer burgholzer deleted the disable-clang-tidy branch July 26, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code Core Anything related to the Core library and IR fix Fix for something that isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant