Skip to content

➕🪝 add new pre-commit hook for running ruff on Jupyter notebooks #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

burgholzer
Copy link
Member

Description

This PR adds a new pre-commit check that allows running ruff also on Jupyter notebooks, which might come in really handy for documentation purposes.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

also adds some documentation comments to other checks
@burgholzer burgholzer added usability Anything related to usability python Anything related to Python code labels Jun 30, 2023
@burgholzer burgholzer added this to the MQT Core milestone Jun 30, 2023
@burgholzer burgholzer self-assigned this Jun 30, 2023
@burgholzer burgholzer enabled auto-merge (squash) June 30, 2023 17:37
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #365 (de4ee9b) into main (e288167) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #365   +/-   ##
=====================================
  Coverage   89.4%   89.4%           
=====================================
  Files         90      90           
  Lines      11859   11859           
  Branches    2132    2132           
=====================================
  Hits       10609   10609           
  Misses      1250    1250           

@burgholzer burgholzer merged commit 2440a72 into main Jun 30, 2023
@burgholzer burgholzer deleted the pre-commit-update branch June 30, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Anything related to Python code usability Anything related to usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant