Actually Populate the Params list from Qobjs #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cpp-Linter Report ✔️No problems need attention. Have any feedback or feature suggestions? Share it here. |
burgholzer
approved these changes
Jun 14, 2023
Codecov Report
@@ Coverage Diff @@
## main #333 +/- ##
=====================================
Coverage 87.4% 87.4%
=====================================
Files 58 58
Lines 6729 6729
Branches 1351 1351
=====================================
Hits 5886 5886
Misses 843 843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the parameters of parameterized gates are not saved when reading in circuits from
QasmQobjExperiments. Previously theparamslist was always empty.Related:
BackendV2ddsim#190