🎨 LLVM code format and Python binding restructure #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## mqt-core #321 +/- ##
==========================================
- Coverage 87.4% 81.6% -5.9%
==========================================
Files 58 60 +2
Lines 6725 7659 +934
Branches 1351 1474 +123
==========================================
+ Hits 5884 6252 +368
- Misses 841 1407 +566
|
|
Ignoring the coverage decrease for now as the much bigger impact for coverage will probably come from moving the DD and ZX package out of the |
… a real library instead of header-only
pybind objects are handles and behave like pointers
burgholzer
changed the title
Cpp-Linter Report ✔️No problems need attention. Have any feedback or feature suggestions? Share it here. |
burgholzer
added a commit
that referenced
this pull request
Jun 15, 2023
This is the main PR that marks the transition from the existing submodule structure towards a unified `mqt-core` package and consists of a series of smaller PRs. For more details on the individual changes please look at: - [x] Transfer DD package from submodule to folder #316 - [x] Transfer ZX package from submodule to folder #317 - [x] Remove `mqt.qfr` Python package and corresponding CI #319 - [x] Consolidate `googletest` submodule #320 - [x] Use stricter `clang-format` config throughout #321 - [x] Move DD package code to main directory #326 - [x] Move ZX package code to main directory #327 - [x] Replace `QFR` with `MQT Core` (ensure backwards compatibility via alias) #328 - [x] Various CI improvements and speedups - #322 - #323 - #324 - #325 - #329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies the
clang-formatconfiguration (closely following the LLVM style) and applies it to all files.The ZX package was mostly formatted according to those rules anyway, so there are hardly any changes there.
Lots of line break and whitespace changes in the DD package and the QFR files though. Might need some cleanup later on.
This also moves the
qfr_pythontarget (which was previously a header-only library) to the main source tree and splits it into header and source files with the main goal of optimizing compile times.