Integrate changes of noise aware simulation #126
Conversation
Codecov Report
@@ Coverage Diff @@
## main #126 +/- ##
=======================================
+ Coverage 83.2% 84.1% +0.8%
=======================================
Files 46 48 +2
Lines 7782 8238 +456
=======================================
+ Hits 6482 6935 +453
- Misses 1300 1303 +3
Continue to review full report at Codecov.
|
# Conflicts: # test/CMakeLists.txt
| for (auto target: op->getTargets()) { | ||
| usedQubits.push_back(target); | ||
| } | ||
| for (auto control: op->getControls()) { | ||
| usedQubits.push_back(control.qubit); | ||
| } |
There was a problem hiding this comment.
this is not guaranteed to work properly. you have to call getUsedQubits on each sub-operation and then add build the union of the current set and the newly generated set. To this end, it is probably easiest and cleanest to just replace the std::vector<dd::Qubit> with a std::set<dd::Qubit> which handles sorting an uniqueness automatically.
If you really need a vector as the result of the call (which I don't think you need), then you can still construct a vector from the set by (pseudocode)
auto vec = std::vector{set.begin(), set.end()};(the union of two sets can be easily be computed in-place by using set1.insert(set2.begin(), set2.end()))
There was a problem hiding this comment.
Indeed! I changed the code as suggested.
Signed-off-by: burgholzer <[email protected]>
This PR adds the latest changes of the noise aware quantum circuit simulation to the QFR.
More precisely, this includes the noise functionality of the stochastic noise aware quantum circuit simulator ) and the deterministic noise aware quantum circuit simulator.