Skip to content

♻️ Specify Install Components for Wheel #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 27, 2025
Merged

♻️ Specify Install Components for Wheel #1021

merged 6 commits into from
Jun 27, 2025

Conversation

ystade
Copy link
Collaborator

@ystade ystade commented Jun 25, 2025

Description

This PR does not immediately solve an issue but contributes to avoiding an issue that arose in #996. In particular, it allows to select the install components explicitly and, hence, avoid installing components that were added by dependencies where install instructions cannot be deactivated, e.g., RE2.

Also in general, I think, it is a good idea to set the install components for the wheel explicitly.

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@ystade ystade self-assigned this Jun 25, 2025
@ystade ystade added python Anything related to Python code packaging Anything related to Python packaging labels Jun 25, 2025
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@ystade ystade requested a review from burgholzer June 25, 2025 11:18
@ystade ystade mentioned this pull request Jun 25, 2025
8 tasks
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking reasonable. From my past experience working on the installation instructions, this really deserves some proper testing. I am especially worried since this will probably no longer install nlohmann_json now.
Can we make sure this works in other repositories that use mqt-core? Most importantly mqt-qmap and especially on Linux.
Running cibuildwheel locally, installing that wheel locally, building mqt-qmap from source without build-isolation (to ensure the local wheel is used), and running the tests.
If that works, I am fairly convinced that this can be merged.
Maybe this also helps with the MLIR Plugin and the conflict that we saw between Catalyst and mqt-core on nlohmann_json.

Co-authored-by: Lukas Burgholzer <[email protected]>
Signed-off-by: Yannick Stade <[email protected]>
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this for now 🚀 We can always fix stuff, if this turns out to be breaking something.

@burgholzer burgholzer merged commit 8073e2e into main Jun 27, 2025
30 checks passed
@burgholzer burgholzer deleted the install-comps branch June 27, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Anything related to Python packaging python Anything related to Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants