-
Notifications
You must be signed in to change notification settings - Fork 42
♻️ Specify Install Components for Wheel #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking reasonable. From my past experience working on the installation instructions, this really deserves some proper testing. I am especially worried since this will probably no longer install nlohmann_json
now.
Can we make sure this works in other repositories that use mqt-core? Most importantly mqt-qmap
and especially on Linux.
Running cibuildwheel
locally, installing that wheel locally, building mqt-qmap from source without build-isolation (to ensure the local wheel is used), and running the tests.
If that works, I am fairly convinced that this can be merged.
Maybe this also helps with the MLIR Plugin and the conflict that we saw between Catalyst and mqt-core on nlohmann_json
.
Co-authored-by: Lukas Burgholzer <[email protected]> Signed-off-by: Yannick Stade <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with this for now 🚀 We can always fix stuff, if this turns out to be breaking something.
Description
This PR does not immediately solve an issue but contributes to avoiding an issue that arose in #996. In particular, it allows to select the install components explicitly and, hence, avoid installing components that were added by dependencies where install instructions cannot be deactivated, e.g., RE2.
Also in general, I think, it is a good idea to set the install components for the wheel explicitly.
Checklist: