Skip to content

✨ Benchmark Registry #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jun 3, 2025
Merged

✨ Benchmark Registry #585

merged 16 commits into from
Jun 3, 2025

Conversation

simon1hofmann
Copy link
Collaborator

Added a benchmark registry and added automatic imports to gatesets and devices.

@github-project-automation github-project-automation bot moved this to In Progress in MQT Applications May 28, 2025
@simon1hofmann simon1hofmann self-assigned this May 28, 2025
@simon1hofmann simon1hofmann added refactor Anything related to refactoring the code base enhancement New feature or request labels May 28, 2025
@codecov Codecov
Copy link

codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@simon1hofmann simon1hofmann requested a review from burgholzer May 30, 2025 11:28
burgholzer
burgholzer requested changes May 30, 2025
View reviewed changes
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this registry approach 👍🏻
Makes the library quite a bit cleaner and more extendable 😎

As always, the devil lies in the details. Hopefully the comments are fairly easy to address.

burgholzer
burgholzer requested changes Jun 3, 2025
View reviewed changes
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great and I believe is practically mergeable. I just have two more comments, which might not result in any code changes after all. I'll approve once the open conversations are resolved 🙂

burgholzer
burgholzer approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really really good!
Feels like a very clean and consistent solution for the registries now across MQT Bench.
Let's get this in, while work on the arithmetic circuits is still ongoing.

@burgholzer burgholzer enabled auto-merge (squash) June 3, 2025 13:35
@burgholzer burgholzer merged commit b1c7621 into munich-quantum-toolkit:main Jun 3, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in MQT Applications Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burgholzer burgholzer burgholzer approved these changes

Assignees

@simon1hofmann simon1hofmann

Labels
enhancement New feature or request refactor Anything related to refactoring the code base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon1hofmann @burgholzer