✨ Implement HHL algorithm #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
burgholzer
approved these changes
May 28, 2025
There was a problem hiding this comment.
This is indeed a fairly limited application of HHL, but still a reasonable one.
In the very end, these circuits are not so different to the QPE circuits we have already. But it is still nice to see.
Random thought: at some point we should actually verify that all of the algorithms here (especially the ones we implement on our own) do the right thing. While not increasingly important from a compiler benchmarking perspective, this becomes increasingly relevant when these algorithms should actually be executed.
Signed-off-by: Nils Quetschlich <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ple times Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Nils Quetschlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite some time ago, the HHL implementation based on
qiskit.algorithmshas been removed. Now, the time has come to re-add this benchmark.In this current implementation, a simplified version is implemented that solves a specific linear equation system and the
num_qubitsscale the number of QPE qubits. This gives the advantages of getting a circuit that actually has the specified number of qubits in comparison to before.However, while I think this implementation could and should be improved in the future, this might be a fair starting point.
This PR resolves #216.