Skip to content

[docs] Fix AI assistant API URL #17745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 7, 2025

This seems wrong, no? Only https://dashboard.render.com/web/srv-cvvovgc9c44c73f6cit0 runs in production.

I guess we can delete this too? https://app.netlify.com/teams/mui/dns/mui.com

SCR-20250508-bomw

On this page:

Avoid exposing the API key to the client by using a proxy server that receives prompt processing requests

The "avoid" feels very strange. Either it's a "must" or this section shouldn't be here in the first place. I would imagine that it should be "must" today, and not be here once we allow developers to whitelist origins.

@oliviertassinari oliviertassinari requested a review from arminmeh May 7, 2025 22:38
Copy link

github-actions bot commented May 7, 2025

Thanks for adding a type label to the PR! 👍

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation labels May 7, 2025
@oliviertassinari oliviertassinari marked this pull request as ready for review May 7, 2025 22:38
@mui-bot
Copy link

mui-bot commented May 7, 2025

@arminmeh
Copy link
Contributor

arminmeh commented May 8, 2025

API is still running from the branch. I will work to have https://github.com/mui/mui-private/pull/695 merged. Then we can remove the DNS records and update the docs.

@joserodolfofreitas I assume no one started building their own service, so it is safe to do it without redirects from the old subdomain?

@oliviertassinari
Copy link
Member Author

@arminmeh What's the blocker to have the AI backend run from a master branch?

no one started building their own service, so it is safe to do it without redirects from the old subdomain?

I think so. But yeah, we need to update https://dashboard.render.com/web/srv-cvvovgc9c44c73f6cit0/env

SCR-20250509-dbpb

@arminmeh
Copy link
Contributor

arminmeh commented May 9, 2025

@arminmeh What's the blocker to have the AI backend run from a master branch?

no one started building their own service, so it is safe to do it without redirects from the old subdomain?

I think so. But yeah, we need to update dashboard.render.com/web/srv-cvvovgc9c44c73f6cit0/env

SCR-20250509-dbpb

@oliviertassinari no blockers. I will move this on top of my queue. Should be finished soon.
Regarding the DNS record and the additional service, we will have to wait until the changes are released to clean things up, otherwise our current demos will stop working.
I will set a reminder for myself to do it

@oliviertassinari
Copy link
Member Author

@arminmeh Alright, at least, from an docs standpoint, I assume that we can move forward with this PR since it's the same URL used by the live demo.

@oliviertassinari oliviertassinari merged commit 20997ff into mui:master May 9, 2025
26 of 27 checks passed
@oliviertassinari oliviertassinari deleted the fix-URL-ai branch May 9, 2025 14:05
JCQuintas pushed a commit to JCQuintas/mui-x that referenced this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants