Skip to content

[docs-infra] Fix Vale no longer working #17602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 30, 2025

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Apr 29, 2025

Copy link

github-actions bot commented Apr 29, 2025

Thanks for adding a type label to the PR! 👍

@mui-bot
Copy link

mui-bot commented Apr 29, 2025

@zannager zannager added the scope: docs-infra Specific to the docs-infra product label Apr 29, 2025
@zannager zannager requested a review from LukasTy April 29, 2025 12:57
title: React Gauge chart
title: React Gauge
Copy link
Member

@oliviertassinari oliviertassinari Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work for SEO, at least, after quickly trying both prompts search queries.

@oliviertassinari oliviertassinari added the regression 🐛 A bug, but worse label Apr 29, 2025
.gitignore Outdated
Comment on lines 23 to 24
# vale downloaded config
.github/styles/Google
.github/styles/MUI
.github/styles/.vale-config
test-results No newline at end of file
.github/styles/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, smart.

@oliviertassinari oliviertassinari removed the request for review from LukasTy April 29, 2025 22:25
@oliviertassinari oliviertassinari changed the title [docs-infra][draft] Test new vale config sharing [docs-infra] Propagate Vale fix Apr 29, 2025
@oliviertassinari oliviertassinari changed the title [docs-infra] Propagate Vale fix [docs-infra] Fix Vale no longer working Apr 29, 2025
@alexfauquette alexfauquette merged commit 81ccb60 into mui:master Apr 30, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression 🐛 A bug, but worse scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants