[code-infra] Latest vitest picker changes #17577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-17577--material-ui-x.netlify.app/ |
LukasTy
reviewed
Apr 28, 2025
| // TODO: temporary for vitest. Can move to `vi.useFakeTimers` | ||
| let timer: SinonFakeTimers | null = null; | ||
| beforeEach(() => { | ||
| timer = useFakeTimers({ now: new Date(2018, 0, 1), toFake: ['Date'] }); |
There was a problem hiding this comment.
Haven't we already tried removing this time mocking and later encountered edge-cases at certain times? 🤔
There was a problem hiding this comment.
I can't remember 🤔
I can also keep it in for this describe block if you think it is best
LukasTy
approved these changes
Apr 28, 2025
oliviertassinari
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as with previous PRs, goal is to trim down changes in the main PR