Skip to content

[code-infra] CI optimization: re-use ffmpeg #17333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025
Merged

[code-infra] CI optimization: re-use ffmpeg #17333

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9082693
build: use playwright ffmpeg
romgrk Apr 11, 2025
cd9bdd1
lint
romgrk Apr 12, 2025
fd82590
lint
romgrk Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,16 @@ commands:
condition: << parameters.playwright >>
steps:
- run:
name: Install playwright
command: pnpx [email protected] install --with-deps
name: Install playwright & ffmpeg
command: |
pnpx [email protected] install --with-deps
# Avoids installing a system version of ffmpeg
ffmpeg_bin=$(find ~/.cache/ms-playwright -regex '.*/ffmpeg-[0-9]*')
if [[ -z "$ffmpeg_bin" ]]; then
>&2 echo "Could not find ffmpeg location"
exit 1
fi
ln -s "$ffmpeg_bin" ~/bin/ffmpeg

jobs:
checkout:
Expand Down Expand Up @@ -293,9 +301,6 @@ jobs:
- install_js:
playwright: true
react-version: << parameters.react-version >>
- run:
name: Install ffmpeg
command: sudo apt update && sudo apt upgrade -y && sudo apt install ffmpeg -y
- run:
name: Run visual regression tests
command: xvfb-run pnpm test:regressions
Expand Down