Skip to content

[support-infra] Fix typeLabels #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 28, 2025
Merged

[support-infra] Fix typeLabels #311

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
90af2fa
[support-infra] Fix typeLabels
oliviertassinari Apr 28, 2025
b45cefe
Apply suggestions from code review
oliviertassinari Apr 28, 2025
ce0058e
Clearer
oliviertassinari Apr 28, 2025
902e6ea
clearer
oliviertassinari Apr 28, 2025
3ce58a1
fix typo
oliviertassinari Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/scripts/prs/checkTypeLabel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ const createEnumerationFromArray = (stringArray) =>
: stringArray.map((s) => `\`${s}\``).join('');

const typeLabels = [
'docs',
'release',
'bug',
'regression',
'maintenance',
'dependencies',
'regression', // a sub-type of bug but we flatten it.
'enhancement',
'new feature',
// Those are not "Types" labels, they are "Kind of work" labels, but we don't want to have to handle the overhead of.
// setting “Types” labels with them.
'release',
'dependencies',
];
const labelRegex = new RegExp(`\\b(${typeLabels.join('|')})\\b`, 'i');

Expand Down