[support-infra] Enhance closing message logic for customer feedback #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check to ensure feedback requests are targeted at issues from paying customers with specific support plans. This change helps focus survey prompts on users with commercial support, improving feedback relevance.
michelengelen
added
enhancement
michelengelen
requested review from
joserodolfofreitas,
oliviertassinari and
mapache-salvaje
mapache-salvaje
approved these changes
Feb 27, 2025
Co-authored-by: Sam Sycamore <[email protected]> Signed-off-by: Michel Engelen <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]> Signed-off-by: Michel Engelen <[email protected]>
oliviertassinari
changed the title
oliviertassinari
added
the
scope: support-infra
oliviertassinari
changed the title
| ); | ||
|
|
||
| // Only ask for feedback if the user is not an admin or doesn't have write access (from a team membership) | ||
| if (!['admin', 'write'].includes(userPermission.data.permission) && isPaidSupport) { |
There was a problem hiding this comment.
Off topic. A note for the future, we could imagine having an opt-in (not opt-out) flag if a repository wants to ask for CSAT for open-source users too.
Usually, this is not needed because in the open-source playbook, the maintainer (product owner/manager) is responsible for his product scope to succeed; she/he's accountable/responsible for support too, he has so much input that CSAT can easily be noise and deleted.
But, if we move to have a strong split in the responsibility between product and support inside open-source scopes and we don't have enough user feedback, then we would need ways to keep the two roles strongly in sync. In those cases, CSAT could serve that purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://mui-org.slack.com/archives/C02P87NQLJC/p1734696964190989 and mui/mui-x#16655 (comment).
Add a check to ensure feedback requests are targeted at issues from paying customers with specific support plans. This change helps focus survey prompts on users with commercial support, improving feedback relevance.
I am not so sure if we should ditch the feedback from community members all together ... it feels wrong and we do get valuable feedback from them. On the other hand I am curious if this will increase conversion rate though. 🤷🏼
Help with #156.