-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[examples] Add material-ui-react-router-ts
example
#46406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
material-ui-react-router-ts
example
Netlify deploy previewhttps://deploy-preview-46406--material-ui.netlify.app/ Bundle size report
|
examples/material-ui-react-router-ts/scripts/unpatch-emotion-packages.js
Outdated
Show resolved
Hide resolved
optimizeDeps: { | ||
include: ['@emotion/*', '@mui/*'], | ||
}, | ||
noExternal: ['@emotion/*', '@mui/*'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😕 This will require the user to add every library that uses emotion in this list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this, great job! Let's work towards removing these vite config in a separate effort.
Alright, let's keep an eye on remix-run/react-router#13871 to remove the |
closes #45878, closes #45873
This PR adds example for Material UI + React Router + Vite