Skip to content

[docs][Grid] Remove direction column from the demo #46127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0210shivam
Copy link

@0210shivam 0210shivam commented May 11, 2025

Fixes #46110

Clarifies that direction="column" is fully supported on the Grid component, correcting a misleading note in the documentation. This update also includes an example and explanation regarding the behavior of direction="column" compared to the default direction="row".

@mui-bot
Copy link

mui-bot commented May 11, 2025

Netlify deploy preview

https://deploy-preview-46127--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 2780b83

@0210shivam 0210shivam marked this pull request as draft May 11, 2025 05:49
@0210shivam 0210shivam marked this pull request as ready for review May 11, 2025 05:58
@0210shivam
Copy link
Author

Hi, could someone from the team please add the documentation label to this PR? It's a fix to clarify the usage of direction="column" in the Grid component documentation (Fixes #46110). Thanks!

@0210shivam 0210shivam force-pushed the fix/docs-grid-direction branch 3 times, most recently from 3712a39 to f8c1f5a Compare May 11, 2025 08:14
@0210shivam
Copy link
Author

@siriwatknp Could you please take a look at this PR when you have time? Thanks!

@0210shivam 0210shivam force-pushed the fix/docs-grid-direction branch from f8c1f5a to 54f9d51 Compare May 11, 2025 15:19
@siriwatknp
Copy link
Member

Thanks for submitting the PR but I think it should be a different way. The column radio should be removed from the demo instead.

#46110 (comment)

@0210shivam 0210shivam force-pushed the fix/docs-grid-direction branch from 54f9d51 to 4100bdb Compare May 12, 2025 02:40
@0210shivam 0210shivam force-pushed the fix/docs-grid-direction branch from 4100bdb to 2780b83 Compare May 12, 2025 03:09
@0210shivam
Copy link
Author

@siriwatknp Thanks! I've removed both column and column-reverse from the demo to avoid confusion. Let me know if anything else needs tweaking.

@siriwatknp siriwatknp changed the title docs(Grid): clarify support for direction='column' [docs][Grid] Remove direction column from the demo May 12, 2025
@siriwatknp siriwatknp added docs Improvements or additions to the documentation component: Grid The React component. package: material-ui Specific to @mui/material labels May 12, 2025
@zannager zannager requested a review from siriwatknp May 12, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Grid The React component. docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Inconsistent information about Grid column
3 participants