-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[core] Remove @mui/base from the master branch #45857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Netlify deploy preview
TablePagination: parsed: +1913.74% , gzip: +1601.94% Bundle size reportDetails of bundle changes (Toolpad) |
@@ -38,7 +38,7 @@ | |||
}, | |||
"dependencies": { | |||
"@babel/runtime": "^7.27.0", | |||
"@mui/base": "workspace:*", | |||
"@mui/base": "7.0.0-beta.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uff, so the version of @mui/base-ui that lives on the v6 branch will actually be 7.0.0-beta.4? Confusing 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am honeslty not sure where this version came from. Maybe @DiegoAndai or @aarongarciah can confirm it, but I don't think this version matters much, because we are not releasing Joy UI from here, so it's kind of a "dead code" anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for 7.0.0-beta.4
is explained in #45565 (comment)
We need a
@mui/base
release with the new package layout because@mui/lab
depends on it. Otherwise,@mui/lab
will fail to import in Node (ESM module with a fake-ESM dependency).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even we're not releasing, I would use version 5.0.0-beta.40-1
here, as it's the version the latest released Joy is using: https://www.npmjs.com/package/@mui/joy/v/5.0.0-beta.52?activeTab=code#:~:text=base%22%3A%20%22-,5.0.0%2Dbeta.40%2D1,-%22
the version of @mui/base-ui that lives on the v6 branch will actually be 7.0.0-beta.4?
I don't think so? If we were to release from v6 (we really shouldn't unless we desperately need to) we would follow the versioning in that branch (>5.0.0-beta.70
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even we're not releasing, I would use version 5.0.0-beta.40-1 here, as it's the version the latest released Joy is using: https://www.npmjs.com/package/@mui/joy/v/5.0.0-beta.52?activeTab=code#:~:text=base%22%3A%20%22-,5.0.0%2Dbeta.40%2D1,-%22
Ok, this makes sense, I am updating it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On, now I remember why I bumped to this version, it was related to esm, bumping it to 5.0.0-beta.40-1 fails with: https://app.circleci.com/pipelines/github/mui/material-ui/152005/workflows/3b5d02dd-a8d2-4584-a16f-4ec612aa988d/jobs/816592. The latest released one may depend on 5.0.0-beta.40-1, but it was not released from this branch. I am reverting back to 7.0.0-beta.4 (it's the same reasoning as @mui/lab).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only thing from my side is #45857 (comment)
Notes: