Skip to content

[core] Remove @mui/base from the master branch #45857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 11, 2025

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Apr 9, 2025

Notes:

  • I kept @mui/base as a dependency in the docs, as some Joy UI demos depends on it, once we remove Joy UI's docs, it would be safe to remove it
  • One broken inheritance in the Joy UI API for the Menu component (I just removed it, it was the only occurence, we probably should reexport Popover component from Joy UI, but I don't think it's worth the effort)
  • all base-ui/* pages redirect to https://v6.mui.com/base-ui/*
  • I kept /base-ui/ to redirect to https://base-ui.com

@mnajdova mnajdova added the core Infrastructure work going on behind the scenes label Apr 9, 2025
@mui-bot
Copy link

mui-bot commented Apr 9, 2025

Netlify deploy preview

TablePagination: parsed: +1913.74% , gzip: +1601.94%
@material-ui/unstyled: parsed: -100.00% 😍, gzip: -100.00% 😍
Select: parsed: +230.82% , gzip: +197.72%
Tabs: parsed: +1488.45% , gzip: +1298.26%
Button: parsed: +1443.41% , gzip: +1181.40%
Switch: parsed: +1547.31% , gzip: +1315.95%
Snackbar: parsed: +1081.76% , gzip: +948.68%
Input: parsed: +1175.16% , gzip: +971.56%
Tab: parsed: +889.77% , gzip: +761.22%
MenuItem: parsed: +788.63% , gzip: +682.47%
Slider: parsed: +515.46% , gzip: +457.44%
Modal: parsed: +553.28% , gzip: +515.49%
Badge: parsed: +1604.44% , gzip: +1321.48%
Menu: parsed: +177.17% , gzip: +164.57%
FormControl: parsed: +1342.39% , gzip: +1150.10%
TabPanel: parsed: +1110.03% , gzip: +923.20%
@material-ui/core/Popper: parsed: -100.00% 😍, gzip: -100.00% 😍
Unstable_Popup: parsed: -100.00% 😍, gzip: -100.00% 😍
TabsList: parsed: -100.00% 😍, gzip: -100.00% 😍
Unstable_NumberInput: parsed: -100.00% 😍, gzip: -100.00% 😍
and 35 more changes

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 51cab2a

@mnajdova mnajdova marked this pull request as ready for review April 9, 2025 15:11
@@ -38,7 +38,7 @@
},
"dependencies": {
"@babel/runtime": "^7.27.0",
"@mui/base": "workspace:*",
"@mui/base": "7.0.0-beta.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uff, so the version of @mui/base-ui that lives on the v6 branch will actually be 7.0.0-beta.4? Confusing 😄

Copy link
Member Author

@mnajdova mnajdova Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am honeslty not sure where this version came from. Maybe @DiegoAndai or @aarongarciah can confirm it, but I don't think this version matters much, because we are not releasing Joy UI from here, so it's kind of a "dead code" anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for 7.0.0-beta.4 is explained in #45565 (comment)

We need a @mui/base release with the new package layout because @mui/lab depends on it. Otherwise, @mui/lab will fail to import in Node (ESM module with a fake-ESM dependency).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even we're not releasing, I would use version 5.0.0-beta.40-1 here, as it's the version the latest released Joy is using: https://www.npmjs.com/package/@mui/joy/v/5.0.0-beta.52?activeTab=code#:~:text=base%22%3A%20%22-,5.0.0%2Dbeta.40%2D1,-%22

the version of @mui/base-ui that lives on the v6 branch will actually be 7.0.0-beta.4?

I don't think so? If we were to release from v6 (we really shouldn't unless we desperately need to) we would follow the versioning in that branch (>5.0.0-beta.70)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even we're not releasing, I would use version 5.0.0-beta.40-1 here, as it's the version the latest released Joy is using: https://www.npmjs.com/package/@mui/joy/v/5.0.0-beta.52?activeTab=code#:~:text=base%22%3A%20%22-,5.0.0%2Dbeta.40%2D1,-%22

Ok, this makes sense, I am updating it.

Copy link
Member Author

@mnajdova mnajdova Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On, now I remember why I bumped to this version, it was related to esm, bumping it to 5.0.0-beta.40-1 fails with: https://app.circleci.com/pipelines/github/mui/material-ui/152005/workflows/3b5d02dd-a8d2-4584-a16f-4ec612aa988d/jobs/816592. The latest released one may depend on 5.0.0-beta.40-1, but it was not released from this branch. I am reverting back to 7.0.0-beta.4 (it's the same reasoning as @mui/lab).

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only thing from my side is #45857 (comment)

@mnajdova mnajdova requested a review from Janpot April 11, 2025 11:00
@mnajdova mnajdova merged commit 2b2c47b into mui:master Apr 11, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants