[styled-engine] Add caching to improve performance for running tests with Jest #45846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-45846--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
siriwatknp
added
v6.x
needs cherry-pick
…/styled-engine-jest
aarongarciah
reviewed
Apr 9, 2025
packages/mui-styled-engine/src/StyledEngineProvider/StyledEngineProvider.js
Outdated
Show resolved
Hide resolved
packages/mui-styled-engine/src/StyledEngineProvider/StyledEngineProvider.test.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Aarón García Hervás <[email protected]> Signed-off-by: Siriwat K <[email protected]>
aarongarciah
approved these changes
Apr 9, 2025
|
Cherry-pick PRs will be created targeting branches: v6.x |
robbtraister
reviewed
Jun 4, 2025
| ); | ||
| const cache = React.useMemo(() => { | ||
| const cacheKey = `${injectFirst}-${enableCssLayer}`; | ||
| if (cacheMap.has(cacheKey)) { |
There was a problem hiding this comment.
FYI, I'm seeing an issue from this change in SSR where emotion thinks a node has already been inserted (because it was on a previous request that is now using a shared cache).
The fix I have patched into my repo is to change this if check to
if (typeof document === 'object' && cacheMap.has(cacheKey)) {There was a problem hiding this comment.
opened PR here: #46276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #45638