[core] Allow repo to be accepted as an argument for releaseTag #45801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-45801--material-ui.netlify.app/ Bundle size report |
brijeshb42
changed the title
brijeshb42
added
core
Janpot
reviewed
Apr 2, 2025
scripts/releaseTag.mjs
Outdated
| @@ -40,12 +42,12 @@ async function findMuiOrgRemote() { | |||
| // - [email protected]:mui/material-ui.git | |||
| // but not: | |||
| // - [email protected]:mui/material-ui-docs.git | |||
| return /mui\/material-ui(\.git)?$/.test(remote.url) && remote.method === '(push)'; | |||
| return new RegExp(`mui/${repo}(.git)?$`).test(remote.url) && remote.method === '(push)'; | |||
There was a problem hiding this comment.
Wouldn't be surprised there's some hidden bugs in this regex still. My advice would be to always avoid regex if proper parsers exist. What do you think about using git-url-parse instead? It's not a new dependency, it's already in the node_modules through lerna.
There was a problem hiding this comment.
mui/${repo}(.git)?$
------------^ this is an "anything" wildcard
| mui/x-chartssgit would match
There was a problem hiding this comment.
Updated to use the parser.
There was a problem hiding this comment.
It would've also matched "not-mui/material-ui.git". 😄
Janpot
approved these changes
Apr 2, 2025
brijeshb42
force-pushed
the
code-infra-release-tag
branch
from
52f35c2 to
468c611
Compare
This will help in reusing this script across repos
brijeshb42
force-pushed
the
code-infra-release-tag
branch
from
468c611 to
a7af6ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help in reusing this script across repos