[AvatarGroup] Fix spacing prop ignoring value 0
#45799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-45799--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
This was referenced Apr 2, 2025
Kartik-Murthy
force-pushed
the
fix/avatar-group-spacing-zero
branch
2 times, most recently
from
60648c3 to
feaffba
Compare
zannager
added
the
component: avatar
Kartik-Murthy
force-pushed
the
fix/avatar-group-spacing-zero
branch
from
feaffba to
84685fe
Compare
ZeeshanTamboli
changed the title
spacing prop should accept value 0
ZeeshanTamboli
changed the title
spacing prop should accept value 0spacing prop not accepting value 0
ZeeshanTamboli
added
bug 🐛
ZeeshanTamboli
added
v6.x
needs cherry-pick
ZeeshanTamboli
changed the title
spacing prop not accepting value 0spacing prop ignoring value 0
Kartik-Murthy
force-pushed
the
fix/avatar-group-spacing-zero
branch
from
01ae186 to
84a8888
Compare
Kartik-Murthy
force-pushed
the
fix/avatar-group-spacing-zero
branch
from
84a8888 to
bb9b936
Compare
- Update AvatarGroup spacing prop logic to handle 0 as a valid value. - Ensures that 0 behaves as expected without causing layout issues.
- Restore original import order as per project conventions
Kartik-Murthy
force-pushed
the
fix/avatar-group-spacing-zero
branch
from
bb9b936 to
00280f8
Compare
|
Thanks @ZeeshanTamboli for reviewing! I’ve added the test case and implemented the changes you suggested. Let me know if anything else is needed. |
aarongarciah
requested review from
siriwatknp
and removed request for
aarongarciah
siriwatknp
approved these changes
Apr 8, 2025
ZeeshanTamboli
approved these changes
Apr 8, 2025
|
Cherry-pick PRs will be created targeting branches: v6.x |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 8, 2025
Co-authored-by: ZeeshanTamboli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
This PR fixes #45797 where the
AvatarGroupcomponent in MUI v7 ignoresspacing={0}and defaults to the standard spacing. This occurred because0was incorrectly treated asfalse.Changes:
Updated the
AvatarGroupcomponent to handlespacing={0}correctly.Ensured that
0is not treated asfalse, allowing no spacing between avatars.Passing
Infinity,-Infinity,NaN,-NaN,1/NaNandundefinedwill default to medium spacing:-8pxThis fix restores expected behavior for
spacing={0}in the MUI v7.Additional
Before: https://codesandbox.io/p/devbox/agitated-johnson-5yx8t9
After fix: https://codesandbox.io/p/sandbox/material-ui-cra-ts-forked-8fmqpp